Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing argument for TextProcessing Manager #39684

Merged
merged 1 commit into from
Aug 3, 2023
Merged

fix: missing argument for TextProcessing Manager #39684

merged 1 commit into from
Aug 3, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Aug 2, 2023 •
edited
Loading

  • Resolves: Failing ci / nodb test

Summary

TODO

  • ...

Checklist

@kesselb kesselb force-pushed the fix/noid/missing-argument-for-text-processing-test branch from c169943 to 773f1b5 Compare August 2, 2023 22:32
@kesselb kesselb force-pushed the fix/noid/missing-argument-for-text-processing-test branch from 773f1b5 to 0098af3 Compare August 2, 2023 22:33
@kesselb kesselb mentioned this pull request Aug 2, 2023
Merged
4 tasks
@kesselb kesselb self-assigned this Aug 2, 2023
@kesselb kesselb added bug 3. to review Waiting for reviews labels Aug 2, 2023
@kesselb kesselb added this to the Nextcloud 28 milestone Aug 2, 2023
@kesselb kesselb requested a review from julien-nc August 2, 2023 22:53
julien-nc
julien-nc approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot and sorry I didn't spot it in the original PR.

@julien-nc julien-nc merged commit 9e096ef into master Aug 3, 2023
36 checks passed
@julien-nc julien-nc deleted the fix/noid/missing-argument-for-text-processing-test branch August 3, 2023 11:03
@kesselb
Copy link
Contributor Author

kesselb commented Aug 3, 2023

Thanks a lot and sorry I didn't spot it in the original PR.

You are welcome, please don't worry 😃
Everyone is just too used to the failing drone runs 🙈

@kesselb kesselb added technical debt and removed bug labels Aug 3, 2023
This was referenced Aug 7, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc approved these changes

@marcelklehr marcelklehr marcelklehr approved these changes

Assignees

@kesselb kesselb

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@kesselb @marcelklehr @julien-nc