Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files): migrate recent view #39613

Merged
merged 1 commit into from
Aug 2, 2023
Merged

feat(files): migrate recent view #39613

merged 1 commit into from
Aug 2, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 28, 2023 •
edited
Loading

  • Using DAV search so we're fully compatible with all required actions metadata
  • Remove old files

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Jul 28, 2023
@skjnldsv skjnldsv requested a review from a team July 28, 2023 12:55
@skjnldsv skjnldsv self-assigned this Jul 28, 2023
@skjnldsv skjnldsv requested review from susnux, Pytal and szaimen and removed request for a team July 28, 2023 12:55
susnux
susnux approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two comments

@szaimen
Copy link
Contributor

szaimen commented Jul 28, 2023 •
edited
Loading

I tested this and looks works pretty fine already! :)

However I found a few small things:

  1. Pressing on any file downloads the file instead of opening in the viewer (but should be fixed by migrating viewer to the new api)
  2. Clicking on a folder in the recent view does not redirect nor open the folder
  3. when a favorited file is displayed at sorted by name, it is shown always on top - probably needs some design decision if it should be shown and sorted on top
  4. when pressing on a folder, navigating back does not open the recent files again (should be fixed by getting rid of legacy view)

@skjnldsv skjnldsv force-pushed the feat/f2v/recent branch 2 times, most recently from 63cdb40 to c1f14f9 Compare August 2, 2023 07:42
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 2, 2023
@skjnldsv
feat(files): migrate recent view
87b1719 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv merged commit 78856f3 into master Aug 2, 2023
45 of 47 checks passed
@skjnldsv skjnldsv deleted the feat/f2v/recent branch August 2, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@susnux susnux susnux approved these changes

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish feature: files
Projects
Files to vue
Status: Done
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @szaimen @susnux @Pytal