fix!: Final round of moving to IEventDispatcher #39605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nickvergessen
force-pushed
the
bugfix/noid/final-events-cleanup
branch
from
30b5d64
to
f9b3e16
Compare
nickvergessen
requested review from
come-nc,
ChristophWurst,
kesselb,
a team,
icewind1991 and
nfebe
and removed request for
a team
15 tasks
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/final-events-cleanup
branch
from
f9b3e16
to
3962cd0
Compare
| @@ -112,7 +113,7 @@ | |||
| private function callForRegistrations() { | |||
| static $eventSent = false; | |||
| if (!$eventSent) { | |||
| \OC::$server->getEventDispatcher()->dispatch( | |||
| \OC::$server->get(IEventDispatcher::class)->dispatch( | |||
Check notice
Code scanning / Psalm
DeprecatedMethod Note
nickvergessen
removed
the
pending documentation
Altahrim
approved these changes
Aug 4, 2023
Comment on lines
+124
to
+128
| if ($addToFavorite) { | ||
| $event = new NodeAddedToFavorite($user, $fileId, $path); | ||
| } else { | ||
| $event = new NodeRemovedFromFavorite($user, $fileId, $path); | ||
| } |
There was a problem hiding this comment.
Nit:
$event = $addToFavorite
? new NodeAddedToFavorite($user, $fileId, $path);
: new NodeRemovedFromFavorite($user, $fileId, $path);There was a problem hiding this comment.
Not a fan of inline-if when generating objects 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist