Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "MFA Verified" check to workflowengine #39471

Closed
wants to merge 33 commits into from

Conversation

mrvahedi68
Copy link

This PR goes together with:

It allows the creation of workflows that depend on whether the logged-in user has passed MFA Verification for the current session or not.

Signed-off-by: MohammadReza vahedi <[email protected]>
@@ -759,6 +767,7 @@
$this->container->query(FileName::class),
$this->container->query(FileSize::class),
$this->container->query(FileSystemTags::class),
$this->container->query(MfaVerified::class),

Check notice

Code scanning / Psalm

DeprecatedMethod Note

The method OCP\IContainer::query has been marked as deprecated
@come-nc
Copy link
Contributor

come-nc commented Sep 4, 2023

Why is there so many commits? Please rebase on master and clean up history.

@michielbdejong
Copy link
Contributor

You're right! Sorry about that. Rebased in #40235

@mrvahedi68 mrvahedi68 closed this Sep 4, 2023
@come-nc
Copy link
Contributor

come-nc commented Sep 4, 2023

You do not need to open another PR each time you can force push to the same branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants