-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "MFA Verified" check to workflowengine #39471
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge with upstream
Merge with upstream
update with nextcloud
Signed-off-by: MohammadReza vahedi <[email protected]>
Signed-off-by: MohammadReza vahedi <[email protected]>
Signed-off-by: MohammadReza vahedi <[email protected]>
thepeak99
approved these changes
Jul 19, 2023
Signed-off-by: MohammadReza vahedi <[email protected]>
@@ -759,6 +767,7 @@ | |||
$this->container->query(FileName::class), | |||
$this->container->query(FileSize::class), | |||
$this->container->query(FileSystemTags::class), | |||
$this->container->query(MfaVerified::class), |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
The method OCP\IContainer::query has been marked as deprecated
Why is there so many commits? Please rebase on master and clean up history. |
You're right! Sorry about that. Rebased in #40235 |
You do not need to open another PR each time you can force push to the same branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes together with:
It allows the creation of workflows that depend on whether the logged-in user has passed MFA Verification for the current session or not.