Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lib/private #39245

Closed
wants to merge 3 commits into from
Closed

Refactor lib/private #39245

wants to merge 3 commits into from

Conversation

shdehnavi
Copy link
Contributor

@shdehnavi shdehnavi commented Jul 8, 2023 •
edited
Loading

Summary

The required adjustments have been made to the following classes under /lib/private namespace:

  • Updater.php
  • TempManager.php
  • Tags.php
  • TagManager.php
  • TemplateLayout.php
  • URLGenerator.php

The improvements:

  • Using PHP8's constructor property promotion
  • Adding return types
  • Adding types to properties
  • Updating doc blocks
  • Replacing substr with PHP8's str_ends_with and str_starts_with

Checklist

@shdehnavi
Refactor lib/private
fcb2c1b 
Signed-off-by: Hamid Dehnavi <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 8, 2023
View reviewed changes
lib/private/TagManager.php Fixed Show fixed Hide fixed
lib/private/TagManager.php Fixed Show fixed Hide fixed
lib/private/TempManager.php Fixed Show fixed Hide fixed
lib/private/TempManager.php Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 8, 2023
View reviewed changes
lib/private/TagManager.php Fixed Show fixed Hide fixed
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 9, 2023
@shdehnavi shdehnavi mentioned this pull request Jul 13, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
@blizzz blizzz mentioned this pull request Jul 30, 2024
Merged
@blizzz blizzz mentioned this pull request Aug 1, 2024
Merged
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsv
Copy link
Member

@shdehnavi thanks for the PR (and all the other ones too! 💪)
Unfortunately, we took a bit too much time to review and get it merged.
We rebased and merged as much as we can for the other, but this one was too conflicting.

If you used a tooling to create those, feel free to run it again now and ping me @skjnldsv straight away! I'll help you get it merged fast 🚀

Have a nice day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
2. developing Work in progress stale Ticket or PR with no recent activity technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shdehnavi @skjnldsv @blizzz @solracsf