Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor "substr" calls in lib/public to improve code readability #39217

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Refactor "substr" calls in lib/public to improve code readability #39217

merged 1 commit into from
Aug 6, 2024

Conversation

shdehnavi
Copy link
Contributor

Summary

Replacing substr with str_ends_with in the /lib/public namespace to improve code readability

Checklist

@shdehnavi shdehnavi changed the title Refactor "substr" calls to improve code readability Refactor "substr" calls in lib/public to improve code readability Jul 7, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 9, 2023
@shdehnavi shdehnavi mentioned this pull request Jul 13, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
Merged
Merged
juliusknorr
juliusknorr requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but needs a rebase and fix of the commit message for conventional commits :)

@skjnldsv skjnldsv closed this Aug 3, 2024
@skjnldsv skjnldsv reopened this Aug 6, 2024
@skjnldsv skjnldsv force-pushed the replace_substr_call_in_lib_public branch from c9e4413 to f19f8fd Compare August 6, 2024 06:47
@skjnldsv skjnldsv merged commit ead0471 into nextcloud:master Aug 6, 2024
158 of 161 checks passed
@Altahrim Altahrim mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
2. developing Work in progress stale Ticket or PR with no recent activity technical debt
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
6 participants
@shdehnavi @nickvergessen @juliusknorr @skjnldsv @blizzz @solracsf