Refactor core/Controller #39212
Closed
Refactor core/Controller #39212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
artonge
reviewed
Jul 17, 2023
nickvergessen
requested changes
Jul 17, 2023
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Louis Chemineau <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
nickvergessen
requested changes
Jul 19, 2023
Comment on lines
124
to
132
| * @param Node $node | ||
| * @param int $x | ||
| * @param int $y | ||
| * @param bool $a | ||
| * @param bool $forceIcon | ||
| * @param string $mode | ||
| * @return Response | ||
| * @throws NotFoundException | ||
| * @throws InvalidPathException |
Comment on lines
89
to
98
| * | ||
| * @param int $fileId | ||
| * @param int $x | ||
| * @param int $y | ||
| * @param bool $a | ||
| * @param bool $forceIcon | ||
| * @param string $mode | ||
| * @return DataResponse|FileDisplayResponse | ||
| * @throws NoUserException | ||
| * @throws NotPermittedException |
Comment on lines
57
to
64
| * @param string $targetUserId | ||
| * @param string $paramId | ||
| * @param string $visibility | ||
| * @return DataResponse | ||
| * @throws OCSBadRequestException | ||
| * @throws OCSForbiddenException | ||
| * @throws OCSNotFoundException | ||
| * @throws Exception |
There was a problem hiding this comment.
another open comment here
Signed-off-by: Hamid Dehnavi <[email protected]>
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
added
2. developing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The required adjustments have been made to the classes in
/core/Controllernamespace.The improvements:
str_starts_withandstr_ends_withinstead ofsubstrChecklist