Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ldap): avatar is not being fetched #39128

Merged
merged 2 commits into from
Sep 11, 2023
Merged

fix(ldap): avatar is not being fetched #39128

merged 2 commits into from
Sep 11, 2023

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jul 3, 2023 •
edited
Loading

Summary

Before leaving early, double check whether the avatar is actually present.

This is a quick attempt based on this observation #35319 (comment), but I have not tested it yet.

Tested now and working.

TODO

  • Testing

Checklist

@blizzz blizzz added this to the Nextcloud 28 milestone Jul 3, 2023
@blizzz blizzz mentioned this pull request Jul 3, 2023
Closed
9 tasks
@blizzz blizzz requested a review from come-nc July 4, 2023 21:20
@blizzz blizzz marked this pull request as ready for review July 5, 2023 14:41
@blizzz blizzz added the 2. developing Work in progress label Jul 5, 2023
@blizzz blizzz force-pushed the fix/35319/ldap-missing-avatar branch from 96d7404 to 92a082d Compare July 5, 2023 15:14
@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 5, 2023
@blizzz blizzz requested review from a team, ArtificialOwl and icewind1991 and removed request for a team July 5, 2023 15:15
@blizzz
Copy link
Member Author

blizzz commented Jul 5, 2023

/backport to stable27

@blizzz
Copy link
Member Author

blizzz commented Jul 5, 2023

/backport to stable26

@blizzz
Copy link
Member Author

blizzz commented Jul 5, 2023

/backport to stable25

come-nc

This comment was marked as resolved.

Sign in to view

@blizzz blizzz force-pushed the fix/35319/ldap-missing-avatar branch from ffb52d9 to 4054a7d Compare July 7, 2023 08:46
@blizzz blizzz requested a review from nfebe July 10, 2023 10:45
@blizzz blizzz requested review from a team, Altahrim and juliusknorr September 11, 2023 15:00
@juliusknorr
Copy link
Member

Failure unrelated

@juliusknorr juliusknorr merged commit 97dd09c into master Sep 11, 2023
@juliusknorr juliusknorr deleted the fix/35319/ldap-missing-avatar branch September 11, 2023 17:43
This was referenced Sep 11, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe

@Altahrim Altahrim Awaiting requested review from Altahrim

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: ldap regression
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[Bug]: Profile Picture from LDAP gone after upgrade to 25
3 participants
@blizzz @juliusknorr @come-nc