Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(updatenotification): Remove deprecated NcPopoverMenu and use NcActions instead #39106

Merged
merged 3 commits into from
Jul 13, 2023
Merged

fix(updatenotification): Remove deprecated NcPopoverMenu and use NcActions instead #39106

merged 3 commits into from
Jul 13, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 2, 2023 •
edited
Loading

Summary

This removes the deprecated NcPopupMenu and replaces it with NcActions.
Other changes within this PR:

  • Cleanup code related to the NcAction migration
    • Fixes also a problem where the "whats new" popover is overlaid by the app navigation, see below
  • Move info text about the update channel under the correct headline for better document structure
  • Fix eslint warnings

Screenshots

What Before After
Overview image image
"Whats new" image image
Update channel image image

Checklist

@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: settings labels Jul 2, 2023
@susnux susnux added this to the Nextcloud 28 milestone Jul 2, 2023
@susnux susnux requested review from kesselb, skjnldsv, nimishavijay, a team, nfebe and Pytal and removed request for a team July 2, 2023 13:08
@susnux susnux changed the title Fix/update notification remove deprecated ncpopupmenu fix(updatenotification): Remove deprecated NcPopoverMenu and use NcActions instead Jul 2, 2023
@susnux susnux mentioned this pull request Jul 2, 2023
Open
14 tasks
@susnux susnux force-pushed the fix/update-notification--remove-deprecated-ncpopupmenu branch from 7b78044 to 2ad00b5 Compare July 12, 2023 15:15
@susnux susnux requested review from artonge and removed request for kesselb July 12, 2023 15:16
@susnux @skjnldsv
fix(updatenotification): Use @nextcloud/l10n to avoid deprecation w…
2d1b5c8 
…arnings

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux @skjnldsv
fix(updatenotification): Remove deprecated NcPopoverMenu and cleanup
c967087 
* Replace `NcPopoverMenu` with `NcActions` and cleanup related code
* Move text under related heading for better content structure
* Fix some eslint warnings

Signed-off-by: Ferdinand Thiessen <[email protected]>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 13, 2023
@skjnldsv
Copy link
Member

Rebasing

@susnux @skjnldsv
chore: Compile assets
8e58c34 
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv force-pushed the fix/update-notification--remove-deprecated-ncpopupmenu branch from 2ad00b5 to 8e58c34 Compare July 13, 2023 08:06
@skjnldsv skjnldsv merged commit c35c42f into master Jul 13, 2023
@skjnldsv skjnldsv deleted the fix/update-notification--remove-deprecated-ncpopupmenu branch July 13, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@Altahrim Altahrim Altahrim approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: settings
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @skjnldsv @Altahrim @Pytal