-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dav properties column types #39084
base: master
Are you sure you want to change the base?
Conversation
a253545
to
b4118da
Compare
@skjnldsv This one is important and I need some help on the database migration. |
Any chance this PR get's some love? |
e06a61d
to
c4be207
Compare
The propertyvalue column can contain null 0x00 characters values because of serializing PHP objects since #30368. This truncates data in text fields, but not blob fields. We start by removing invalid value and altering the column to match the new type. That's what Sabre PDO's being doing in the first place 🙈 Closes #37754 Signed-off-by: Thomas Citharel <[email protected]>
Match it to the value in oc_filecache table path column should be fine. Closes #9907 Signed-off-by: Thomas Citharel <[email protected]>
Signed-off-by: Thomas Citharel <[email protected]>
c4be207
to
1440e5a
Compare
For PostgreSQL : https://stackoverflow.com/questions/19300113/unable-to-convert-postgresql-text-column-to-bytea If we have less than 50k rows (value yet to determine), perform the migrations straight away. |
Summary
propertyvalue
fromTEXT
type toBLOB
as it may contain null 0x00 characters because of php serialization DAV properties propertyvalue column has wrong column type #37754propertypath
column length Error reporting for too long filepaths (>255 chars) #9907If changing the type of the column can't be done, we'll need to create a new column and move data
TODO
Checklist