fix(settings): Migrate away from deprecated NcPopoverMenu
#39073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nfebe,
skjnldsv,
a team and
Pytal
and removed request for
a team
14 tasks
skjnldsv
approved these changes
Jun 29, 2023
Pytal
approved these changes
Jun 30, 2023
* Replace popover menu with `NcActions` * Deduplicate user actions code between `UserRow` and `UserRowSimple` * Fix user action to cover whole row heigh to prevent dropdown from shining through the actions * Fix user action popover to be overlayed by current edited row actions Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Pytal
force-pushed
the
fix/setting_migrate-from-deprecated-ncpopovermenu
branch
from
ceebd62
to
e36fc97
Compare
nfebe
approved these changes
Jun 30, 2023
Pytal
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NcPopoverMenuis deprecated and removed in the upcoming nextcloud vue release, so this migrates the settings app to useNcActionsinstead. Also there are some other improvements:NcActionsUserRowandUserRowSimple*1 Fix user action popover to be overlaid by current edited row actions *1
Checklist