Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors lib/private/Contacts. #38986

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Refactors lib/private/Contacts. #38986

merged 1 commit into from
Jun 25, 2023

Conversation

fsamapoor
Copy link
Member

Following previous PRs taking advantage of PHP8's constructor property promotion in /core/ namespace, I have also made the required adjustments to the classes in /lib/private/Contacts namespace.

The improvements in this PRs include:

  • Using PHP8's constructor property promotion
  • Adding return types
  • Removing redundant docblocks

@fsamapoor
Refactors lib/private/Contacts.
9f2487d 
Mainly using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <[email protected]>
@szaimen szaimen added 3. to review Waiting for reviews technical debt labels Jun 25, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Jun 25, 2023
@szaimen szaimen requested review from tcitworld, Pytal, a team, ArtificialOwl, icewind1991 and nfebe and removed request for a team June 25, 2023 08:59
nfebe
nfebe approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 25, 2023
@skjnldsv skjnldsv merged commit 31663ac into nextcloud:master Jun 25, 2023
@fsamapoor fsamapoor deleted the refactor_lib_private_contacts branch March 8, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@nfebe nfebe nfebe approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld

@Pytal Pytal Awaiting requested review from Pytal

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@fsamapoor @nfebe @skjnldsv @szaimen