Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wordings : Enhancement of background and UI color change thanks to better title and description #38670

Merged
merged 1 commit into from
May 2, 2024
Merged

Wordings : Enhancement of background and UI color change thanks to better title and description #38670

merged 1 commit into from
May 2, 2024

Conversation

Jerome-Herbinet
Copy link
Member

Summary

Everything is in the PR's title and in the commit.

Checklist

@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-ui-colour-concept branch from 6e1e780 to d1198b4 Compare June 6, 2023 13:39
@Jerome-Herbinet
Copy link
Member Author

Question :
Some other files than "dist/theming-personal-theming.js" and "dist/theming-personal-theming.js.map" have been generated by my first "npm run build", but haven't been regerated after by my others "npm run build". Is this normal ?

jancborchardt
jancborchardt requested changes Jun 8, 2023
View reviewed changes
apps/theming/src/UserThemes.vue Outdated Show resolved Hide resolved
apps/theming/src/UserThemes.vue Outdated Show resolved Hide resolved
jancborchardt
jancborchardt approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-ui-colour-concept branch from f5ebedb to 0819284 Compare June 8, 2023 13:30
@solracsf solracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@blizzz blizzz mentioned this pull request Nov 22, 2023
Merged
5 tasks
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Feb 28, 2024 •
edited
Loading

@Jerome-Herbinet can you rebase and solve the conflicts? :)
I'd like to merge this 🚀

@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Feb 28, 2024
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv force-pushed the Jerome-Herbinet-ui-colour-concept branch from 0819284 to cce2c93 Compare May 2, 2024 14:44
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish bug and removed 2. developing Work in progress stale Ticket or PR with no recent activity labels May 2, 2024
@skjnldsv skjnldsv force-pushed the Jerome-Herbinet-ui-colour-concept branch from cce2c93 to acf2ea3 Compare May 2, 2024 14:46
@skjnldsv skjnldsv force-pushed the Jerome-Herbinet-ui-colour-concept branch from acf2ea3 to fc371b2 Compare May 2, 2024 14:46
@skjnldsv skjnldsv enabled auto-merge May 2, 2024 15:42
@skjnldsv skjnldsv disabled auto-merge May 2, 2024 16:32
@skjnldsv skjnldsv merged commit 6ead79e into master May 2, 2024
102 of 104 checks passed
@skjnldsv skjnldsv deleted the Jerome-Herbinet-ui-colour-concept branch May 2, 2024 16:32
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: theming
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
5 participants
@Jerome-Herbinet @skjnldsv @jancborchardt @blizzz @solracsf