-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files : Left panel dropdown improvement for NC 25 #38338
Files : Left panel dropdown improvement for NC 25 #38338
Conversation
@Jerome-Herbinet do you have some screenshots? |
Could you check the previous PR that contained the same commits #38217 ? |
Can you please add them to the PRs description? |
Done :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but didnt test
btw, why is the dropdown button of shares not shown all the time?
Can somebody test the Mail app with this PR ? |
Mail is using the vue components so this specific PR should not change the behaviour there... |
moving to 25.0.8 |
Why is it open against stable25 in first place? |
Because starting with 26 the files app uses the vue component. 25 still has the old aidebar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvement to make it more obvious @Jerome-Herbinet!
One thing I also noted in the other PR: The triangle pointing to the right is confusing, it would be expected to have a triangle pointing down when in closed state, indicating more things open downwards. :)
When open, the arrow should still point down too. Then it would behave exactly like a standard HTML select element.
It should be OK with the commit I just made @jancborchardt ; could you test it ? |
... and concerning the other PR, I'll do a complementary PR a little later because #38338 has already been merged. |
moving to 25.0.9 |
What's the outlook here? |
moving to 25.0.10 |
moving to 25.0.11 |
@Jerome-Herbinet what’s the current state here? :) If you need help with the frontend/compilation, maybe @juliushaertl @susnux can advise? |
Signed-off-by: Jérôme Herbinet <[email protected]>
Signed-off-by: Jérôme Herbinet <[email protected]>
0837a77
to
7e6c1c7
Compare
@Jerome-Herbinet Otherwise the PR seems to be fine. |
New PR #39779 |
Respawn of #38217 (which is now closed)
Before :
before.2.webm
After :
after.2.webm
Checklist