Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] Add commands for basic file actions #38250

Merged
merged 5 commits into from
Oct 11, 2023
Merged

[stable26] Add commands for basic file actions #38250

merged 5 commits into from
Oct 11, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented May 15, 2023 •
edited by icewind1991
Loading

  • ⚠️ This backport had conflicts that were resolved with the 'ours' merge strategy and is likely incomplete

backport of #37971

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 26.0.2 milestone May 15, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems May 15, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@blizzz blizzz mentioned this pull request May 16, 2023
Merged
@blizzz blizzz added the 2. developing Work in progress label May 17, 2023
@blizzz
Copy link
Member

blizzz commented May 17, 2023

backport incomplete

@blizzz blizzz mentioned this pull request Jun 12, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Jun 15, 2023

moving to 26.0.4

@blizzz blizzz mentioned this pull request Jul 10, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Jul 13, 2023

moving to 26.0.5

@blizzz blizzz mentioned this pull request Aug 2, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Aug 3, 2023

moving to 26.0.6

If there are no updates in any form until building 26.0.6, I will close this PR.

@blizzz blizzz mentioned this pull request Sep 5, 2023
Merged
@icewind1991
add command to get a file from the filesystem
19d64e8 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991
add command to delete a file
1daf6a8 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991
move get/delete commands to files namespace, make get take the output…
b248d56 
… as argument instead of option

Signed-off-by: Robin Appelman <[email protected]>
@icewind1991
add command to write a file
29fd9ac 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991
minor fixes for get/put
2f662bf 
Signed-off-by: Robin Appelman <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 6, 2023
View reviewed changes
apps/files/lib/Command/Get.php
return 1;
}
$source = $node->fopen('r');
if (!$source) {

Check notice

Code scanning / Psalm

DocblockTypeContradiction Note

Operand of type false is always false
apps/files/lib/Command/Get.php
return 1;
}
$source = $node->fopen('r');
if (!$source) {

Check notice

Code scanning / Psalm

DocblockTypeContradiction Note

Docblock-defined type resource for $source is never falsy
apps/files/lib/Command/Put.php
}
if ($node instanceof File) {
$target = $node->fopen('w');
if (!$target) {

Check notice

Code scanning / Psalm

DocblockTypeContradiction Note

Operand of type false is always false
apps/files/lib/Command/Put.php
}
if ($node instanceof File) {
$target = $node->fopen('w');
if (!$target) {

Check notice

Code scanning / Psalm

DocblockTypeContradiction Note

Docblock-defined type resource for $target is never falsy
@icewind1991 icewind1991 marked this pull request as ready for review September 6, 2023 12:50
@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 7, 2023
@blizzz
Copy link
Member

blizzz commented Sep 7, 2023

moving to 26.0.7 due to missing reviews, but thanks @icewind1991 for bringing this back to life

This was referenced Sep 20, 2023
Closed
Merged
@blizzz blizzz mentioned this pull request Oct 9, 2023
Merged
@blizzz blizzz merged commit 09d352f into stable26 Oct 11, 2023
39 checks passed
@blizzz blizzz deleted the backport/37971/stable26 branch October 11, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@blizzz blizzz blizzz approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@icewind1991 icewind1991

Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 26.0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@blizzz @come-nc @icewind1991