-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not allow to toggle between password and text in sharing #37954
Merged
artonge
merged 1 commit into
master
from
artonge/fix/do_not_allow_to_show_pwd_in_sharing
May 10, 2023
Merged
Do not allow to toggle between password and text in sharing #37954
artonge
merged 1 commit into
master
from
artonge/fix/do_not_allow_to_show_pwd_in_sharing
May 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
requested review from
skjnldsv,
Pytal and
szaimen
and removed request for
a team
April 27, 2023 13:36
Since this needs a vue lib update, lets convert it into a draft... |
This was referenced May 3, 2023
Merged
Closed
Merged
/rebase |
/rebase |
Pytal
approved these changes
May 9, 2023
skjnldsv
approved these changes
May 9, 2023
artonge
force-pushed
the
artonge/fix/do_not_allow_to_show_pwd_in_sharing
branch
2 times, most recently
from
May 9, 2023 15:23
62e8117
to
3bd2884
Compare
This does not makes sense as we do not have the clear text value. Signed-off-by: Louis Chemineau <[email protected]>
nextcloud-command
force-pushed
the
artonge/fix/do_not_allow_to_show_pwd_in_sharing
branch
from
May 9, 2023 15:37
3bd2884
to
12fd72d
Compare
artonge
force-pushed
the
artonge/fix/do_not_allow_to_show_pwd_in_sharing
branch
from
May 9, 2023 15:41
12fd72d
to
6faf8b8
Compare
CI failure unrelated |
This was referenced Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not make sense as we do not have the clear text value.