Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale ocdialog based on screen size to contain more information on big screens #37773

Closed
wants to merge 1 commit into from
Closed

Scale ocdialog based on screen size to contain more information on big screens #37773

wants to merge 1 commit into from

Conversation

SuperSandro2000
Copy link

Summary

Before:

image

After:

image

TODO

  • test with a deployment, I only changed the values in the css because I didn't have the time to set up a nextcloud development environment

Checklist

@szaimen szaimen added the 3. to review Waiting for reviews label Apr 17, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone Apr 17, 2023
@szaimen szaimen requested review from a team, skjnldsv, Pytal and szaimen and removed request for a team April 17, 2023 16:35
Comment on lines +537 to +538
width: '70vw',
height: '60vh',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have a max-width and max-height as well but not sure what values would be best, @jancborchardt @skjnldsv?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and min too 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not super good in css, should I set the following:

Suggested change
width: '70vw',
height: '60vh',
mix-width: '70vw',
max-width: '70vw',
min-height: '60vh',
max-height: '60vh',

or

Suggested change
width: '70vw',
height: '60vh',
mix-width: '600',
width: '70vw',
min-height: '500',
height: '60vh',

?

This was referenced May 3, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@SuperSandro2000 SuperSandro2000 closed this by deleting the head repository Jan 6, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants