Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): standardize files:node:event event syntax #37726

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

@skjnldsv skjnldsv added enhancement 3. to review Waiting for reviews feature: files pending documentation This pull request needs an associated documentation update labels Apr 14, 2023
@skjnldsv skjnldsv added this to the Nextcloud 27 milestone Apr 14, 2023
@skjnldsv skjnldsv self-assigned this Apr 14, 2023
@skjnldsv skjnldsv requested review from a team, artonge, Pytal, szaimen, juliusknorr and julien-nc and removed request for a team April 14, 2023 07:31
@szaimen szaimen removed their request for review April 14, 2023 07:33
@juliusknorr
Copy link
Member

For notes we can add a version check then

@juliusknorr juliusknorr merged commit 8a79636 into master Apr 14, 2023
@juliusknorr juliusknorr deleted the feat/files-events branch April 14, 2023 09:30
artonge added a commit to nextcloud/photos that referenced this pull request Apr 17, 2023
Needed after: nextcloud/server#37726

Signed-off-by: Louis Chemineau <[email protected]>
nextcloud-command pushed a commit to nextcloud/photos that referenced this pull request Apr 17, 2023
Needed after: nextcloud/server#37726

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
artonge added a commit to nextcloud/photos that referenced this pull request Apr 17, 2023
Needed after: nextcloud/server#37726

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@DaphneMuller
Copy link

Hello!
Thank you for your work on this! I noticed that your PR still has the label 'documentation'. I'm not sure if you already had a look at the documentation for your PR, but at Nextcloud we strive to document changes that affect other app developers or other admins before the release takes place, and I'm pinging you with the hope to get this done.

Are you familiar with our documentation process already?
Changes that affect app developers should be documented here:
https://docs.nextcloud.com/server/27/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_27.html

Changes that affect administrators should be documented here:
https://docs.nextcloud.com/server/latest/admin_manual/release_notes/upgrade_to_27.html

While I understand sometimes it's handy to merge fast to get your changes in, it would be great if next time you could try to add the documentation before merging. You can find more information on that here:
https://docs.nextcloud.com/server/27/developer_manual/prologue/compatibility_app_ecosystem.html#documentation-procedures-of-changes-that-affect-app-developers

If all your documentation efforts are done, please remove the label 'documentation' and check the checkbox in your opening note and I'll stop bugging you :)

Many thanks in advance and thanks again for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement feature: files pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants