fix: log fopen calls when stream isn't available #37624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
icewind1991
approved these changes
Apr 12, 2023
icewind1991
requested review from
a team,
ArtificialOwl and
blizzz
and removed request for
a team
miaulalala
added
3. to review
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
fix/logging-for-failed-fopen
branch
from
e5e5559
to
70a6eee
Compare
blizzz
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By recommendation from @icewind1991 trying this on 27 to see if the failed tests in #37284 are down to stable20 being broken or actually breaking stuff.