Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MigrateBackgroundImages on oracle #36453

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 31, 2023

Summary

->andWhere($selector->expr()->eq('configvalue', $selector->createNamedParameter('custom')))
fails on oracle as configvalue is a longtext which is not allowed in where clauses without casting.

This is the same approach also used in

->andWhere($qb->expr()->eq(
$qb->expr()->castColumn('configvalue', IQueryBuilder::PARAM_STR),
$qb->createNamedParameter($value, IQueryBuilder::PARAM_STR))

Checklist

@juliusknorr juliusknorr force-pushed the bugfix/noid/oci-longtext branch 2 times, most recently from 41d373b to 6c42353 Compare January 31, 2023 09:19
@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Jan 31, 2023
@juliusknorr juliusknorr changed the title bugfix/noid/oci longtext Fix MigrateBackgroundImages on oracle Jan 31, 2023
@juliusknorr juliusknorr added this to the Nextcloud 26 milestone Jan 31, 2023
@juliusknorr
Copy link
Member Author

/backport to stable25

@juliusknorr juliusknorr marked this pull request as ready for review January 31, 2023 09:23
@juliusknorr
Copy link
Member Author

Pushed another commit to test if passing PARAM_STR to the eq function also works, as this should cast also looking at the implementation of the OCIExpressionBuilder

@nickvergessen
Copy link
Member

Pushed another commit to test if passing PARAM_STR to the eq function also works, as this should cast also looking at the implementation of the OCIExpressionBuilder

Should adjust the runtime code now as well?

Signed-off-by: Julius Härtl <[email protected]>

test: try with just passing the type to eq which should also cast

Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr juliusknorr merged commit ca3f53a into master Jan 31, 2023
@juliusknorr juliusknorr deleted the bugfix/noid/oci-longtext branch January 31, 2023 14:27
@juliusknorr
Copy link
Member Author

Failures unrelated.

@juliusknorr
Copy link
Member Author

/backport ecccff8 to stable25

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants