Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not open the sidebar automatically on small widths #36409

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jan 27, 2023

For my own testing
docker run -it \
--name nextcloud-easy-test \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.24.128 \
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
-e SERVER_BRANCH=enh/noid/dont-automatically-open-sidebar-on-mobile \
-e VIEWER_BRANCH=master \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added the 2. developing Work in progress label Jan 27, 2023
@szaimen szaimen added this to the Nextcloud 26 milestone Jan 27, 2023
apps/files/js/filelist.js Outdated Show resolved Hide resolved
@szaimen szaimen force-pushed the enh/noid/dont-automatically-open-sidebar-on-mobile branch 3 times, most recently from 361dbd1 to a26801b Compare January 27, 2023 13:32
@blizzz blizzz mentioned this pull request Feb 1, 2023
@szaimen szaimen force-pushed the enh/noid/dont-automatically-open-sidebar-on-mobile branch 4 times, most recently from 115d86a to e07ca6c Compare February 2, 2023 17:51
@szaimen szaimen force-pushed the enh/noid/dont-automatically-open-sidebar-on-mobile branch from 4a7e665 to 7fa42a2 Compare February 2, 2023 18:01
@szaimen szaimen added enhancement 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 2, 2023
@szaimen szaimen marked this pull request as ready for review February 2, 2023 18:02
@szaimen szaimen requested review from a team, artonge, skjnldsv and Pytal and removed request for adityaraute and a team February 2, 2023 18:02
@szaimen
Copy link
Contributor Author

szaimen commented Feb 2, 2023

/backport to stable25

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 3, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Feb 3, 2023

CI failure inrelated

@szaimen szaimen merged commit a579b36 into master Feb 3, 2023
@szaimen szaimen deleted the enh/noid/dont-automatically-open-sidebar-on-mobile branch February 3, 2023 09:08
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen szaimen restored the enh/noid/dont-automatically-open-sidebar-on-mobile branch February 3, 2023 09:48
@szaimen szaimen deleted the enh/noid/dont-automatically-open-sidebar-on-mobile branch February 3, 2023 09:51
@ChristophWurst
Copy link
Member

/backport to stable25

@ChristophWurst

This comment was marked as resolved.

@szaimen

This comment was marked as resolved.

@ChristophWurst

This comment was marked as resolved.

@backportbot-nextcloud

This comment was marked as resolved.

@ChristophWurst

This comment was marked as resolved.

@blizzz blizzz mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants