Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(caldav): Fix wrong Psalm report for nullable calendar data #36380

Merged
merged 1 commit into from
Jan 27, 2023
Merged

fix(caldav): Fix wrong Psalm report for nullable calendar data #36380

merged 1 commit into from
Jan 27, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jan 26, 2023 •
edited
Loading

  • Resolves:

Summary

Docblock-defined type Sabre\VObject\Component\VCalendar for $vcalendar is never falsy

^ is a lie

Checklist

@ChristophWurst
fix(caldav): Fix wrong Psalm report for nullable calendar data
954284f 
> Docblock-defined type Sabre\VObject\Component\VCalendar for $vcalendar is never falsy

^ is a lie

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews technical debt feature: caldav Related to CalDAV internals labels Jan 26, 2023
@ChristophWurst ChristophWurst added this to the Nextcloud 26 milestone Jan 26, 2023
@ChristophWurst ChristophWurst self-assigned this Jan 26, 2023
@ChristophWurst
Copy link
Member Author

/backport to stable25

@ChristophWurst
Copy link
Member Author

/backport to stable24

st3iny
st3iny approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ඞ

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 26, 2023
@ChristophWurst ChristophWurst merged commit df0bb91 into master Jan 27, 2023
@ChristophWurst ChristophWurst deleted the fix/caldav/reminder-service-nullable-calendar-data branch January 27, 2023 14:43
This was referenced Jan 27, 2023
Merged
Merged
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcitworld tcitworld tcitworld approved these changes

@st3iny st3iny st3iny approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish feature: caldav Related to CalDAV internals technical debt
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @st3iny @tcitworld