Bugfix/32630/get access list use correct array key

[ASerbinski]

• Resolves: [Bug]: getAccessList in ShareByMailProvider uses incorrect array key #32630

Summary

Switch to correct array key in ShareByMailProvider/getAccessList -- should be 'mail' not 'public'.

[kesselb]

Thank you very much 👍

Can you have a look at the failing test:

1) OCA\ShareByMail\Tests\ShareByMailProviderTest::testGetAccessList
Failed asserting that an array has the key 'public'.

/home/runner/work/server/server/apps/sharebymail/tests/ShareByMailProviderTest.php:1089

[kesselb]

Thank you 👍

Please revert the changes to composer.lock

[ASerbinski]

Hi @kesselb ; that commit seems to have been brought in from master during rebase?

[ASerbinski]

@kesselb ; think I cleared it up by rebasing again.

[kesselb]

Thank you 👍

I read the discussion in #2834 to understand public and mail.
If I understand it correct, public is fine and the documentation is wrong.

server/lib/private/Share20/Manager.php

Lines 1761 to 1763 in f5c361c

	} else {
	$al[$k] = $al[$k] || $v;
	}

The above code will "merge" the values together.
If something is shared by MailShareProvider or LinkShareProvider public should be true.

I believe that's good news for your other pull request.

[ASerbinski]

Hi @kesselb ; I believe that the documentation is correct and that the PR #2834 you referenced is from a more primitive state before the 'mail' key was added.

Per @schiessle ; "... To make it more generic we could also add another key 'mail' to the array, which would probably be the better solution."

[kesselb]

I believe that the documentation is correct and that the PR #2834 you referenced is from a more primitive state before the 'mail' key was added.

The documentation for mail was added with the mentioned pr.

To make it more generic we could also add another key 'mail' to the array, which would probably be the better solution.

I guess that was an idea, but not done.

The takeaway for your pull request to list the mail shares for a node is to keep the current behavior (add public = true when at least one mail share exist) and add the mail attribute to the result.

I'm unsure if we need this pr. There is nothing broken to be fixed apart from the documentation. Sorry, for asking you to create a pull request for this change.

[ASerbinski]

Hi @kesselb ; I added a commit to #32631 to comply with your directive to both preserve the prior behavior with respect to the 'public' array key, and to use the 'mail' key per proposed new usage.