Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 32bit support and add workflow for 32bits testing #36120

Merged
merged 32 commits into from
Feb 7, 2023
Merged

Fix 32bit support and add workflow for 32bits testing #36120

merged 32 commits into from
Feb 7, 2023

Commits on Feb 7, 2023

  1. Add workflow for 32bits testing 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    3885818 View commit details
    Browse the repository at this point in the history

  2. Revert "remove 32-bit workarounds" 

    This reverts commit dd87743.

Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    e156f83 View commit details
    Browse the repository at this point in the history

  3. Running all tests on 32bits to see what happens 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    b370fdb View commit details
    Browse the repository at this point in the history

  4. Add apcu and ffmpeg to have less skipped tests 

    Also exclude test groups which rely on a service

Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    2d8e696 View commit details
    Browse the repository at this point in the history

  5. Strong type filesize related methods to ease 32bits problem findings 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    ff776a9 View commit details
    Browse the repository at this point in the history

  6. Fix psalm errors related to filesizes 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    d9dbed9 View commit details
    Browse the repository at this point in the history

  7. Improve test failure output for RouterTest.php 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    5cfab22 View commit details
    Browse the repository at this point in the history

  8. Fix bigsize support on 32bits in OC_Helper 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    255f230 View commit details
    Browse the repository at this point in the history

  9. Fix filesize return type error in ViewTest 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    0f8c34c View commit details
    Browse the repository at this point in the history

  10. Add helper to cast to int|float, fix MemoryInfo on 32bits 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    94ecae4 View commit details
    Browse the repository at this point in the history

  11. Fix 32bits bigint support in Util/OC_Helper 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    7a628c0 View commit details
    Browse the repository at this point in the history

  12. Fix a few tests that were using too big int values for 32bits 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    0753be3 View commit details
    Browse the repository at this point in the history

  13. Fix computerFileSize when called with a string without unit 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    d00422b View commit details
    Browse the repository at this point in the history

  14. Fix setQuota on User on 32bits 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    5aed587 View commit details
    Browse the repository at this point in the history

  15. Allow float sizes in FileInfo for 32bits 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    5c1a0e0 View commit details
    Browse the repository at this point in the history

  16. Type sizes as int|float throughout the code base 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    cd885b5 View commit details
    Browse the repository at this point in the history

  17. Improve error output on failed Router test 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    77c8c9c View commit details
    Browse the repository at this point in the history

  18. Silence errors of return type mismatch from Sabre for now 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    110fc79 View commit details
    Browse the repository at this point in the history

  19. Improve behavior with dates on 32bits and fix tests or skip them 

    We do not support events after 2038 on 32bits but still behave better
 when date range start/end is after 2038.

Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    d315bce View commit details
    Browse the repository at this point in the history

  20. Put back string in $includeMounts as it actually does something 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    b7d9e43 View commit details
    Browse the repository at this point in the history

  21. Fix name of skip method for phpunit 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    db80ac0 View commit details
    Browse the repository at this point in the history

  22. Fix psalm errors 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    028c225 View commit details
    Browse the repository at this point in the history

  23. Fix Sabre connector test 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    1994554 View commit details
    Browse the repository at this point in the history

  24. Psalm easy fixes in apps/files/appinfo/routes.php 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    885e54e View commit details
    Browse the repository at this point in the history

  25. Skip buggy tests for 32bits CI 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    892e6c6 View commit details
    Browse the repository at this point in the history

  26. Skip tests that cannot succeed on 32bits 

    For some reason a timestamp in the past also triggers the PHP error
 about not being able to represent it as an int, so skipping that test
 on 32bits.

Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    476d5dc View commit details
    Browse the repository at this point in the history

  27. Only run 32bit CI once a day 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    33b5207 View commit details
    Browse the repository at this point in the history

  28. Document that size may be a float in new class VersionEntity 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    1765908 View commit details
    Browse the repository at this point in the history

  29. Removed catch of ValueError as we cannot know if it’s >2038 or <1970 

    Also fixed numericToString to correctly convert float to int if it fits

Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    c4d90f3 View commit details
    Browse the repository at this point in the history

  30. Move back typing to phpdoc to keep backward compatibility in OCP 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    09a97ad View commit details
    Browse the repository at this point in the history

  31. Respect OCP interface in private classes 

    Because the parameter type was moved to phpdoc it needs to be removed
 from implementations

Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    308fcf4 View commit details
    Browse the repository at this point in the history

  32. Show logs on smb-kerberos CI failure 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    6e276ad View commit details
    Browse the repository at this point in the history