Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend path-prefix optimizer to remove all cases of path_hash= when encountering a path prefix filter #36097

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jan 11, 2023

Currently it only removes the path_hash= that is part of the path prefix, however the query might container other path filters which can interfere with the index selection.

See #28608 for the motivation behind the optimization pass

…ncountering a path prefix filter

Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 11, 2023
@icewind1991 icewind1991 added this to the Nextcloud 26 milestone Jan 11, 2023
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, blizzz and come-nc and removed request for a team January 11, 2023 15:42
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@icewind1991 icewind1991 merged commit 5024f29 into master Apr 3, 2023
@icewind1991 icewind1991 deleted the path-prefix-optimize branch April 3, 2023 14:39
@icewind1991
Copy link
Member Author

/backport to stable26

@icewind1991
Copy link
Member Author

/backport to stable25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants