Port Files navigation to vue #35772

skjnldsv · 2022-12-14T15:55:22Z

Fix later

Breadcrumbs behind navigation collapse button
Add copy to clipboard for webdav link
Fix favorite live update

Follow-ups

Nuke snap.js
Release and update webpack config
Update vue components for apps using the Settings API
- https://github.com/nextcloud/text/blob/78e1e6e69f0e8752440bd58e03f74b2a98dd4876/src/files.js#L53
- https://github.com/nextcloud/recommendations/blob/a8a58005083ef0f649d48ddd584c33ba0a0f26ee/src/main.js#L68

github-advanced-security

Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

skjnldsv · 2022-12-28T14:36:57Z

package.json

    "@cypress/browserify-preprocessor": "^3.0.2",
    "@nextcloud/babel-config": "^1.0.0",
    "@nextcloud/cypress": "^1.0.0-beta.1",
    "@nextcloud/eslint-config": "^8.0.0",
    "@nextcloud/stylelint-config": "^2.1.2",
+    "@nextcloud/webpack-vue-config": "github:nextcloud/webpack-vue-config#master",


no be replaced with newly released webpack-vue-config when released

apps/files/lib/Service/UserConfig.php

apps/files/lib/AppInfo/Application.php

@@ -88,7 +89,8 @@
 				$c->get(IPreview::class),
 				$c->get(IShareManager::class),
 				$c->get(IConfig::class),
-				$server->getUserFolder()
+				$server->getUserFolder(),


apps/files/lib/Controller/ApiController.php

-	public function showHiddenFiles(bool $show): Response {
-		$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_hidden', $show ? '1' : '0');
+	public function showHiddenFiles(bool $value): Response {
+		$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_hidden', $value ? '1' : '0');


apps/files/lib/Controller/ApiController.php

-	public function cropImagePreviews(bool $crop): Response {
-		$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'crop_image_previews', $crop ? '1' : '0');
+	public function cropImagePreviews(bool $value): Response {
+		$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'crop_image_previews', $value ? '1' : '0');


apps/files/lib/Controller/ApiController.php

-		$response->setStatus(Http::STATUS_FORBIDDEN);
-		return $response;
+
+		$userId = $this->userSession->getUser()->getUID();


apps/files/lib/Controller/ViewController.php

@@ -205,11 +194,11 @@
 		// FIXME: Make non static
 		$storageInfo = $this->getStorageInfo();

-		$user = $this->userSession->getUser()->getUID();
+		$userId = $this->userSession->getUser()->getUID();


apps/files/lib/Service/UserConfig.php

+	 * @param string $key a valid config key
+	 * @return string|bool
+	 */
+	private function getDefaultConfigValue(string $key): mixed {


apps/files/lib/Service/UserConfig.php

szaimen

Works very well in my testing (apart from the small things that Vincent mentioned) but didnt review the code.

PVince81

👍 no critical issues

the only one that annoys me is the left sidebar behavior but needs handling separately (nextcloud-vue)

apps/files/src/views/Navigation.cy.ts

apps/files/src/views/Settings.vue

package.json

PVince81 · 2023-01-04T10:52:43Z

@skjnldsv please tick the checkboxes and link to tickets for the follow ups to move forward

I did some testing and apart from my above comments I didn't find anything, it works nicely.

Great job! 🎉

Signed-off-by: John Molakvoæ <[email protected]>

skjnldsv · 2023-01-04T15:50:43Z

Come on! This time it's the one! Final rebase (™)

PVince81 · 2023-01-04T16:55:37Z

🎉

szaimen · 2023-01-04T16:59:45Z

🎉🎉🎉🎉🎉

skjnldsv added enhancement 2. developing Work in progress labels Dec 14, 2022

skjnldsv added this to the Nextcloud 26 milestone Dec 14, 2022

skjnldsv self-assigned this Dec 14, 2022

skjnldsv force-pushed the feat/files2vue-navigation branch from fbff70e to 4a0b9c4 Compare December 21, 2022 16:19

github-advanced-security bot found potential problems Dec 21, 2022

View reviewed changes

skjnldsv force-pushed the feat/files2vue-navigation branch from 4a0b9c4 to 8c87ea0 Compare December 28, 2022 14:35

skjnldsv commented Dec 28, 2022

View reviewed changes

skjnldsv force-pushed the feat/files2vue-navigation branch from 8c87ea0 to c9a366e Compare December 28, 2022 17:15

github-advanced-security bot found potential problems Dec 28, 2022

View reviewed changes

skjnldsv force-pushed the feat/files2vue-navigation branch 4 times, most recently from e087bd5 to 8524f6b Compare December 29, 2022 08:55

github-advanced-security bot found potential problems Dec 29, 2022

View reviewed changes

apps/files/lib/Service/UserConfig.php Outdated

* @param string $key a valid config key

* @return string|bool

*/

private function getDefaultConfigValue(string $key): mixed {

Check failure

Code scanning / Psalm

ReservedWord

mixed is a reserved word

skjnldsv force-pushed the feat/files2vue-navigation branch 2 times, most recently from a9403ba to f8f06c0 Compare December 30, 2022 16:03

come-nc reviewed Jan 3, 2023

View reviewed changes

apps/files/lib/Service/UserConfig.php Show resolved Hide resolved

skjnldsv force-pushed the feat/files2vue-navigation branch 8 times, most recently from 4259dad to 10a0c81 Compare January 3, 2023 18:09

skjnldsv marked this pull request as ready for review January 3, 2023 18:36

skjnldsv requested review from a team and removed request for a team January 3, 2023 18:36

szaimen approved these changes Jan 4, 2023

View reviewed changes

PVince81 approved these changes Jan 4, 2023

View reviewed changes

apps/files/src/views/Navigation.cy.ts Outdated Show resolved Hide resolved

apps/files/src/views/Settings.vue Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

skjnldsv mentioned this pull request Jan 4, 2023

Remove unused legacy ajax/list.php in files app #35980

Merged

8 tasks

skjnldsv force-pushed the feat/files2vue-navigation branch from 1233ead to c172ef3 Compare January 4, 2023 11:14

skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 4, 2023

skjnldsv force-pushed the feat/files2vue-navigation branch from c172ef3 to a254b72 Compare January 4, 2023 12:36

skjnldsv added 10 commits January 4, 2023 16:45

Port Files navigation to vue

887c9e0

Signed-off-by: John Molakvoæ <[email protected]>

Port settings to Modal

5c987a0

Signed-off-by: John Molakvoæ <[email protected]>

Fix preview crop

8f1bf13

Signed-off-by: John Molakvoæ <[email protected]>

Add component testing

5b9a8f0

Signed-off-by: John Molakvoæ <[email protected]>

Fixing tests

0a3ef8b

Signed-off-by: John Molakvoæ <[email protected]>

Add component testing workflow

e2da30a

Signed-off-by: John Molakvoæ <[email protected]>

Fix favourite opening

7339355

Signed-off-by: John Molakvoæ <[email protected]>

Hide settings when empty

b9d3e17

Signed-off-by: John Molakvoæ <[email protected]>

fix(files): Settings & cypress fixes

811ba0b

Signed-off-by: John Molakvoæ <[email protected]>

feat(files): Add clipboard copy to webdav url in files settings

6249732

Signed-off-by: John Molakvoæ <[email protected]>

skjnldsv force-pushed the feat/files2vue-navigation branch from a254b72 to 6249732 Compare January 4, 2023 15:49

skjnldsv merged commit e235c64 into master Jan 4, 2023

skjnldsv deleted the feat/files2vue-navigation branch January 4, 2023 16:54

skjnldsv mentioned this pull request Jan 4, 2023

feat(files): Quota in navigation #36002

Merged

4 tasks

This was referenced Jan 5, 2023

fix(files): Make sure that static routes on /apps/files still work #36008

Merged

Fix cypress tests after new files app sidebar nextcloud/text#3643

Merged

ShGKme mentioned this pull request Sep 29, 2023

[Bug]: open shared folder doesn't work #39565

Closed

8 tasks

ShGKme mentioned this pull request Oct 31, 2023

[stable27] fix(files): race condition on web files view change #41206

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port Files navigation to vue #35772

Port Files navigation to vue #35772

skjnldsv commented Dec 14, 2022 •

edited

Loading

github-advanced-security bot left a comment

skjnldsv Dec 28, 2022

szaimen left a comment

PVince81 left a comment

PVince81 commented Jan 4, 2023

skjnldsv commented Jan 4, 2023

PVince81 commented Jan 4, 2023

szaimen commented Jan 4, 2023

Port Files navigation to vue #35772

Port Files navigation to vue #35772

Conversation

skjnldsv commented Dec 14, 2022 • edited Loading

Fix later

Follow-ups

github-advanced-security bot left a comment

Choose a reason for hiding this comment

skjnldsv Dec 28, 2022

Choose a reason for hiding this comment

szaimen left a comment

Choose a reason for hiding this comment

PVince81 left a comment

Choose a reason for hiding this comment

PVince81 commented Jan 4, 2023

skjnldsv commented Jan 4, 2023

PVince81 commented Jan 4, 2023

szaimen commented Jan 4, 2023

skjnldsv commented Dec 14, 2022 •

edited

Loading