-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display name fix for thunderbird #35553
display name fix for thunderbird #35553
Conversation
It's odd we should have to do this. 🤔 |
@tcitworld i checked this and the case is display name is blank in case of thunderbird mail client. |
This issue is really frustrating , is it solved? |
@ChristophWurst what do you think? Also cc @sorbaugh since it touches the server code base. |
$senderName = $this->userManager->getDisplayName($this->userId); | ||
} | ||
//if sender name is empty sometimes in case of email client | ||
if ($senderName === null || empty(trim($senderName))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see how the user triggering the request wouldn't have a display name, but the "sender" of the itip message have one.
Can you offer steps to reproduce this reliably?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked invites sent to me via Thunderbird. There is none with a sender "via Nextcloud". They all have the senders name prefixed.
@avinash-0007 there was a few comments that went unanswered 😕 |
On thunderbird email invitation send calendar missing Display Name calendar#4784
Summary
TODO
Checklist