Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display name fix for thunderbird #35553

Closed

Conversation

avinash-0007
Copy link

Summary

TODO

  • ...

Checklist

@tcitworld
Copy link
Member

It's odd we should have to do this. 🤔

@szaimen szaimen added the 3. to review Waiting for reviews label Dec 2, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Dec 2, 2022
@avinash-0007
Copy link
Author

@tcitworld i checked this and the case is display name is blank in case of thunderbird mail client.

@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@OlexTratisky
Copy link

This issue is really frustrating , is it solved?

@AndyScherzinger
Copy link
Member

@ChristophWurst what do you think? Also cc @sorbaugh since it touches the server code base.

Comment on lines 181 to +184
$senderName = $this->userManager->getDisplayName($this->userId);
}
//if sender name is empty sometimes in case of email client
if ($senderName === null || empty(trim($senderName))) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see how the user triggering the request wouldn't have a display name, but the "sender" of the itip message have one.

Can you offer steps to reproduce this reliably?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked invites sent to me via Thunderbird. There is none with a sender "via Nextcloud". They all have the senders name prefixed.

This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsv
Copy link
Member

@avinash-0007 there was a few comments that went unanswered 😕
As a cleanup step, we've closed that PR. If you want to take it back up again and re-open after addressing those comments, we'll be happy to help 🙏 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress stale Ticket or PR with no recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants