Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup comments code #35424

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Cleanup comments code #35424

merged 3 commits into from
Jun 20, 2023

Commits on Jun 20, 2023

  1. Cleanup comments code 

    - Fix various psalm issues
- Add as much typing as possible while preserving stable API

Signed-off-by: Carl Schwan <[email protected]>
    @CarlSchwan @come-nc
    CarlSchwan authored and come-nc committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9725d00 View commit details
    Browse the repository at this point in the history

  2. Improve typing in ICommentsManager 

    Signed-off-by: Carl Schwan <[email protected]>
    @CarlSchwan @come-nc
    CarlSchwan authored and come-nc committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    77355a8 View commit details
    Browse the repository at this point in the history

  3. Throw if creation date is read before inserting into database 

    Signed-off-by: Côme Chilliet <[email protected]>
    @come-nc
    come-nc committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    7aa97dc View commit details
    Browse the repository at this point in the history