Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show success on share actions #35271

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Show success on share actions #35271

merged 1 commit into from
Dec 3, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Nov 18, 2022 •
edited
Loading

Screenshots

image
image
image
image

@Pytal Pytal added this to the Nextcloud 26 milestone Nov 18, 2022
@Pytal Pytal self-assigned this Nov 18, 2022
@Pytal
Copy link
Member Author

Pytal commented Nov 18, 2022

/backport to stable25

@Pytal Pytal mentioned this pull request Nov 18, 2022
Closed
10 tasks
@Pytal Pytal requested a review from PVince81 November 23, 2022 01:29
PVince81
PVince81 approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 see minor comment, otherwise looks good

@Pytal
Copy link
Member Author

Pytal commented Nov 24, 2022

/rebase

JuliaKirschenheuter
JuliaKirschenheuter approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

nimishavijay
nimishavijay approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Pytal
Show success on share actions
7c943c5 
Signed-off-by: Christopher Ng <[email protected]>
@szaimen szaimen merged commit 31ec83f into master Dec 3, 2022
@szaimen szaimen deleted the enh/a11y-share-success branch December 3, 2022 18:55
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 3, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishavijay nimishavijay nimishavijay approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@PVince81 PVince81 PVince81 approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility feature: sharing
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
5 participants
@Pytal @PVince81 @JuliaKirschenheuter @nimishavijay @szaimen