-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix check if the certificate bundle needs to be updated #350
Conversation
@schiessle, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @LukasReschke and @DeepDiver1975 to be potential reviewers |
I dont think it's correct since it now checks the mtime of the bundle it's going to write |
… specific certificate bundle if a user is given
c493791
to
49cad15
Compare
ok, I see your point. I updated the PR, now it should be correct. |
👍 |
Makes sense 👍 |
Ops, didnt see the open unit test task |
@nickvergessen no problem... will add them in a second PR |
always check the mtime of the system bundle and additionally the user specific certificate bundle if a user is given.
I think this is how the function should look like, @icewind1991 and @LukasReschke please have a look. Thanks!