Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix check if the certificate bundle needs to be updated #350

Merged
merged 1 commit into from
Jul 11, 2016

Conversation

schiessle
Copy link
Member

@schiessle schiessle commented Jul 8, 2016

always check the mtime of the system bundle and additionally the user specific certificate bundle if a user is given.

I think this is how the function should look like, @icewind1991 and @LukasReschke please have a look. Thanks!

@schiessle schiessle added bug 3. to review Waiting for reviews labels Jul 8, 2016
@schiessle schiessle added this to the Nextcloud Next milestone Jul 8, 2016
@mention-bot
Copy link

@schiessle, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @LukasReschke and @DeepDiver1975 to be potential reviewers

@icewind1991
Copy link
Member

I dont think it's correct since it now checks the mtime of the bundle it's going to write

… specific certificate bundle if a user is given
@schiessle schiessle force-pushed the fix-check-certificate-bundles branch from c493791 to 49cad15 Compare July 8, 2016 16:24
@schiessle
Copy link
Member Author

I dont think it's correct since it now checks the mtime of the bundle it's going to write

ok, I see your point. I updated the PR, now it should be correct.

@icewind1991
Copy link
Member

👍

@nickvergessen
Copy link
Member

Makes sense 👍

@nickvergessen nickvergessen merged commit 103417f into master Jul 11, 2016
@nickvergessen nickvergessen deleted the fix-check-certificate-bundles branch July 11, 2016 09:04
@nickvergessen
Copy link
Member

Ops, didnt see the open unit test task

@schiessle
Copy link
Member Author

@nickvergessen no problem... will add them in a second PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants