Fixed Dashboard widgets height #34583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix NC 25 Dashboard widget is height are off #34582 Signed-off-by: Andy Xheli <[email protected]>
AndyXheli
changed the title
|
I'm fine with this change but I wonder if this could rather be fixed in a cleaner way by removing the top margin of NcEmptyContent. |
|
@julien-nc do you mind making a request change ? I'd be happy apply it :) |
|
@AndyXheli I'm refering to a change in https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcEmptyContent/NcEmptyContent.vue But I'm not sure it's the right thing to do either. I guess the empty content top margin has a purpose. Any idea about a clean fix for that? @marcoambrosini @jancborchardt @juliushaertl |
|
Alternative fix nextcloud-libraries/nextcloud-vue#3372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix NC 25 Dashboard widget is height are off #34582
Signed-off-by: Andy Xheli [email protected]