Dynamically adjustment for footer height

[RyanAveritt]

Footer height is dynamically adjusted to 95px if one of the legal links is set; originally 65px. (first-time contributor)
Fix #34305

[RyanAveritt]

Checking in; is there anything else I need to do? Also, any feedback and/or advice would be highly welcomed.

[skjnldsv]

Suggested change

	if(document.querySelectorAll("a.legal").length > 0) document.getElementById("body-public").querySelector('footer').style = 'height: 95px'
	if (document.querySelectorAll('a.legal').length > 0) {
	document.getElementById('body-public').querySelector('footer').style = 'height: 95px'
	}

[skjnldsv]

But I think @szaimen have another fix somewhere?
I'm not super sure this is the way to go 🤔

[jotoeri]

Wouldnt it be better to have a class footer--large or so in public.css and insert the class (dynamically) on the template? That would insert it from ground up instead of altering the height afterwards. 🤔

server/core/css/public.scss

Line 70 in 5ab021c

/* public footer */

server/core/templates/layout.public.php

Line 94 in 5ab021c

<footer>

[szaimen]

+1 for the global css variable approach

[skjnldsv]

+1 for the global css variable approach

Careful about too much variables, we're defeating the initial goal of them

[jotoeri]

+1 for the global css variable approach

Careful about too much variables, we're defeating the initial goal of them

Nah, was not thought as global variable (from my side), but just a class overriding the height:

footer {
    height: 65px;

    .footer--large {
        height: 80px;
    }
}

[szaimen]

+1 for the global css variable approach

Careful about too much variables, we're defeating the initial goal of them

Right. However since we have mutliple places where we need to reuse that one, I guess adding one for that is probably the best idea...

[jotoeri]

However since we have mutliple places where we need to reuse that one, I guess adding one for that is probably the best idea...

Could you point to where they are calculated and set?

[szaimen]

See https://github.com/nextcloud/server/search?q=%24footer-height

[jotoeri]

See https://github.com/nextcloud/server/search?q=%24footer-height

Uhm, maybe i understood wrong, but aren't these just variables within the scss sheet, but will be compiled to fixed numbers within the finally loaded css? Which is sth. different than global css variables var(--footer-height), that could be used within apps then?

[szaimen]

Uhm, maybe i understood wrong, but aren't these just variables within the scss sheet, but will be compiled to fixed numbers within the finally loaded css? Which is sth. different than global css variables var(--footer-height), that could be used within apps then?

indeed. That is why I would push towards a global css variable that could get reused or changed

[jotoeri]

That is why I would push towards a global css variable that could get reused or changed

Ok 👍 . But then my question was related to give a hint to RyanAveritt on where the variable var(--footer-height) can be calculated (depending on the footer-content) and inserted into the loaded variables. This i don't know currently by my own, so i can't tell anything on that. Probably somewhere in the theming app, which also produces the footer-content?

[szaimen]

Ok 👍 . But then my question was related to give a hint to RyanAveritt on where the variable var(--footer-height) can be calculated (depending on the footer-content) and inserted into the loaded variables. This i don't know currently by my own, so i can't tell anything on that. Probably somewhere in the theming app, which also produces the footer-content?

I don't know if we can make a logic from that. Rather changing the varialbe to e.g. 95px if impressum gets activated?

[jotoeri]

Rather changing the varialbe to e.g. 95px if impressum gets activated?

Yeah, thats what i meant. 😄 Just probably a bit bad formulated. Having a variable, that is either 65px or 95px. (While 95 seems a bit much to me, 80px or even less should suffice iirc. #30586)

[skjnldsv]

As there is no feedback since a while I will close this ticket. If this is still happening please make sure to upgrade to the latest version. After that, feel free to reopen.