Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure invalid images don't flood the log file #3439

Merged
merged 2 commits into from
Feb 16, 2017
Merged

Make sure invalid images don't flood the log file #3439

merged 2 commits into from
Feb 16, 2017

Conversation

nickvergessen
Copy link
Member

Upstream 26963

@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Feb 10, 2017
@nickvergessen nickvergessen added this to the Nextcloud 12.0 milestone Feb 10, 2017
@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tanghus, @Kondou-ger and @butonic to be potential reviewers.

This was referenced Feb 10, 2017
Merged
Merged
Merged
@blizzz
Copy link
Member

blizzz commented Feb 10, 2017

There was 1 failure:

  1. OCA\Files_External\Tests\Storage\SmbTest::testNotifyGetChanges
    Failed asserting that an array contains OC\Files\Notify\RenameChange Object &00000000413754ab000000005176f3dc (
    'targetPath' => 'renamed.txt'
    'type' => 4
    'path' => 'newfile.txt'
    ).
    /drone/src/github.com/nextcloud/server/apps/files_external/tests/Storage/SmbTest.php:114
    FAILURES!
    Tests: 84, Assertions: 292, Failures: 1.

Does not seem related … but was this failing (sporadically) earlier?

@LukasReschke
Copy link
Member

Does not seem related … but was this failing (sporadically) earlier?

@icewind1991 Any idea about this? :)

@icewind1991
Copy link
Member

Any idea about this? :)

Ignore it for now, will see if I can make that test more reliable later

@LukasReschke LukasReschke merged commit cf582a6 into master Feb 16, 2017
@LukasReschke LukasReschke deleted the oc-26963 branch February 16, 2017 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

@LukasReschke LukasReschke LukasReschke approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nickvergessen @mention-bot @blizzz @LukasReschke @icewind1991 @VicDeo