-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename users to account or person #34178
Conversation
8d4de1e
to
79d887b
Compare
I've fixed the unit tests locally, I'll push after I see the acceptance test results... some rely on texts/labels sometimes |
79d887b
to
3136a35
Compare
I've pushed even more renames here |
/compile amend / |
3136a35
to
82ace7d
Compare
42e100f
to
83fc72a
Compare
as it's a bit late considering the string freeze and also the fact that other apps need adjusting as well, let's not merge this for 25.0.0 but 25.0.1 could do this would give us time also to properly review all the strings that were replaced and see how they look like in context |
Where is "user status" used in these cases? Cause just "Status" might be enough? "the status feature", "set your status", "people can set their status" etc. For "user documentation" → "Usage documentation". German equivalent would be "Benutzerhandbuch" → "Benutzungshandbuch". |
@jancborchardt I rechecked and it seems the only place where "User status" is visible is for admins as it's the name of the app that can be disabled. And it appears in few debug messages, but that's all. Should we leave it as is ? |
83fc72a
to
8b50e5e
Compare
Rebased and renamed "User documentation" to "Usage documentation" |
b7cf9e6
to
5a2ca05
Compare
apps/files/lib/Activity/Provider.php
Outdated
@@ -163,7 +163,7 @@ public function parseShortVersion(IEvent $event, IEvent $previousEvent = null) { | |||
|
|||
if (!isset($parsedParameters['user'])) { | |||
// External user via public link share | |||
$subject = str_replace('{user}', $this->activityLang->t('"remote user"'), $subject); | |||
$subject = str_replace('{user}', $this->activityLang->t('"remote person"'), $subject); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not 'remote account' ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jancborchardt for feedback
This comment was marked as resolved.
This comment was marked as resolved.
2858f49
to
693e2cf
Compare
aa2c934
to
42d99d1
Compare
42d99d1
to
a00b92f
Compare
Replace translated text in most locations Signed-off-by: Vincent Petry <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
a00b92f
to
524ed97
Compare
Replace translated texts from "user" to either "account" or "people" depending on context
Resolves #32720