Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make config file saving safe against write failures" #34137

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Revert "Make config file saving safe against write failures" #34137

merged 1 commit into from
Sep 19, 2022

Conversation

nickvergessen
Copy link
Member

Reverts #34009

PVince81
PVince81 approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Sep 19, 2022
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Sep 19, 2022
@PVince81 PVince81 added the 4. to release Ready to be released and/or waiting for tests to finish label Sep 19, 2022
@blizzz blizzz mentioned this pull request Sep 19, 2022
Merged
@nickvergessen nickvergessen mentioned this pull request Sep 19, 2022
Merged
@blizzz blizzz merged commit f13b608 into master Sep 19, 2022
@blizzz blizzz deleted the revert-34009-safe-config-update branch September 19, 2022 13:11
@come-nc come-nc mentioned this pull request Nov 15, 2022
Closed
@dagguh
Copy link

dagguh commented Dec 28, 2022

Why revert?

@nickvergessen
Copy link
Member Author

See comments in #34009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@PVince81 PVince81 PVince81 approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
5 participants
@nickvergessen @dagguh @PVince81 @blizzz @come-nc