-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate CA certificate bundle update #34107
Conversation
Signed-off-by: Joas Schilling <[email protected]>
Thank you 👍 If the update is automated the old check can probably go: https://github.com/nextcloud/server/blob/master/build/ca-bundle-checker.sh |
Interesting that we have this check and it never failed.... |
server/build/ca-bundle-checker.sh Lines 3 to 6 in 3a75e14
uuuuuuuuuuuuuuff |
Signed-off-by: Joas Schilling <[email protected]>
It failed sometimes ;) However the check for a certain branch name was always unstable. The schedule based workflow is much better. |
Signed-off-by: Joas Schilling <[email protected]>
@@ -0,0 +1,42 @@ | |||
name: Update CA certificate bundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add your copyright here. I'll be fine if we could adopt spdx notation to make it shorter
# SPDX-FileCopyrightText: 2022 Your name <email>
# SPDX-License-Identifier: AGPL-3.0-or-later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's "high" enough to have copyright
Signed-off-by: Joas Schilling [email protected]