Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unresponsive legacy password confirmation dialog when another modal is open with new dialog in Vue #34044

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Fix unresponsive legacy password confirmation dialog when another modal is open with new dialog in Vue #34044

merged 1 commit into from
Sep 14, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Sep 13, 2022 •
edited
Loading

Without this the focus would remain on the previously opened modal and prevent confirmation of your password

Also improves accessibility

Steps

  1. Open user management page
  2. Create a new user with the modal
  3. Confirm your password

The appendChild console error can be ignored and is fixed upstream in nextcloud-libraries/nextcloud-vue#3219

@Pytal Pytal added this to the Nextcloud 25 milestone Sep 13, 2022
@Pytal Pytal self-assigned this Sep 13, 2022
@Pytal Pytal mentioned this pull request Sep 13, 2022
Closed
@Pytal Pytal changed the title Fix unresponsive legacy password confirmation dialog when another modal is open with dialog in Vue Fix unresponsive legacy password confirmation dialog when another modal is open with new dialog in Vue Sep 13, 2022
PVince81
PVince81 approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member 

error    Unable to resolve path to module '@nextcloud/password-confirmation/style.css'

@PVince81
Copy link
Member

I'll investigate the issue

@PVince81
Copy link
Member

very strange, compilation actually works and the dialog also works
it's only eslint that doesn't seem to be able to load the password-confirmation lib

@PVince81
Copy link
Member

possibly https://stackoverflow.com/q/67648680

I also didn't find any other place where we'd be importing css modules from a non-local module.
Not sure if we should change it to require() now or something else.

@nickvergessen nickvergessen mentioned this pull request Sep 13, 2022
Closed
@Pytal Pytal mentioned this pull request Sep 13, 2022
Merged
@Pytal
Copy link
Member Author

Pytal commented Sep 13, 2022

Analysis and upstream fix in nextcloud-libraries/nextcloud-password-confirmation#393

Pending next package release to resolve all errors

@Pytal Pytal added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 13, 2022
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 14, 2022
@Pytal Pytal merged commit bd03c79 into master Sep 14, 2022
@Pytal Pytal deleted the fix/password-confirmation branch September 14, 2022 19:54
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@PVince81 PVince81 PVince81 approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @PVince81 @ChristophWurst @CarlSchwan