Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove transparent top #34023

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Remove transparent top #34023

merged 1 commit into from
Sep 12, 2022

Conversation

CarlSchwan
Copy link
Member

Replace 3px of absolute positioning with top padding.

Fix #33949

@CarlSchwan
Remove transparent top
79b2dcb 
Replace 3px of absolute positioning with top padding.

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan added 3. to review Waiting for reviews accessibility labels Sep 12, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Sep 12, 2022
@CarlSchwan CarlSchwan requested review from szaimen and a team September 12, 2022 08:06
@CarlSchwan CarlSchwan self-assigned this Sep 12, 2022
@CarlSchwan CarlSchwan requested review from PVince81 and skjnldsv and removed request for a team September 12, 2022 08:06
szaimen
szaimen requested changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear this doesnt close the issue completely (have look at the screenshot: the background color below that gap is still transparent)

@CarlSchwan
Copy link
Member Author

I fear this doesnt close the issue completely (have look at the screenshot: the background color below that gap is still transparent)

But I think this is a design decision from before the UI redesign, since this is using the same backdrop-filter blur settings we also use in the profile page and left sidebars

@szaimen
Copy link
Contributor

szaimen commented Sep 12, 2022

But I think this is a design decision from before the UI redesign, since this is using the same backdrop-filter blur settings we also use in the profile page and left sidebars

okay, but we should fix this, no?

PVince81
PVince81 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit e85ca5c into master Sep 12, 2022
@PVince81 PVince81 deleted the remove-transparent-top-files branch September 12, 2022 13:13
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen requested changes

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@CarlSchwan CarlSchwan

Labels
3. to review Waiting for reviews accessibility ui-refresh-feedback
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

header transparent
3 participants
@CarlSchwan @szaimen @PVince81