Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avatar icons in user list when using dark theme #34022

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

CarlSchwan
Copy link
Member

Fix #34006

@CarlSchwan CarlSchwan added the 4. to release Ready to be released and/or waiting for tests to finish label Sep 12, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Sep 12, 2022
@CarlSchwan CarlSchwan self-assigned this Sep 12, 2022
@szaimen szaimen added ui-refresh-feedback 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Sep 12, 2022
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm then but didn't test

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit c22d44b into master Sep 12, 2022
@PVince81 PVince81 deleted the fix/dark-avatar-user-list branch September 12, 2022 13:14
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
@AndyXheli
Copy link

Hi @CarlSchwan Im not sure if i should creat a new ticker or we can reopen ticket #34006

Same results on NC 25 Beta 7

imageimage

@nursoda
Copy link

nursoda commented Sep 19, 2022

Same results on NC 25 Beta 7

@AndyXheli You DID Shift-Reload, right? Caching seems to do odd things with the new theming…

@AndyXheli
Copy link

Hey @nursoda Yes I did! Cleared cache, tried different browsers same results not sure if it matters users are populating via LDAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Avatar New style looks weird
5 participants