-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IAPIWidget, IButtonWidget and IIconWidget in user status #33940
Implement IAPIWidget, IButtonWidget and IIconWidget in user status #33940
Conversation
248e4fd
to
3c34d74
Compare
3c34d74
to
19b5052
Compare
@tobiasKaminsky The text includes the status unicode character (the UTF-8 emoji). So when there is no emoji, title starts with a space. This is fixed now. About the round icon, tough decision to make. Potential solutions, just elaborating what you said:
I prefer 1. because it is generic and implemented one single time in each client rather than potentially making the effort of rounding the image in each server widget class. |
Then let us go with 1. |
This lacks IItemOptionWidget so that we have item_icons_round:true ? |
19b5052
to
11391d0
Compare
rebased and set |
Tested & worked 👍 |
be2b7b6
to
2600d0b
Compare
@icewind1991 Thanks for the adjustments! |
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
11391d0
to
5b25f94
Compare
Rebased on |
Or we can make the final review in the original PR #33658 |
This is based on #33658
requires:
No buttons for this widget. Use the app svg icon for
getIconUrl()
.