Fix Calendar tests mocking a non-existant method. #33906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no ITimeFactory::getTimestamp method, only getTime Signed-off-by: Côme Chilliet <[email protected]>
come-nc
requested review from
miaulalala,
a team,
ArtificialOwl,
icewind1991 and
CarlSchwan
and removed request for
a team
CarlSchwan
previously approved these changes
Sep 5, 2022
miaulalala
previously approved these changes
Sep 5, 2022
Signed-off-by: Côme Chilliet <[email protected]>
|
@miaulalala I fixed the errors, but the tests are still failing. Tests were added by #33001 |
Merged
|
I'll take over if you like |
Signed-off-by: Anna Larch <[email protected]>
Signed-off-by: Anna Larch <[email protected]>
|
Drone failure is acceptance for filesharing |
CarlSchwan
approved these changes
Sep 8, 2022
ChristophWurst
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no ITimeFactory::getTimestamp method, only getTime
Signed-off-by: Côme Chilliet [email protected]