Add getShareTypesInFolder to optimize folder listening #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icewind1991, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81, @rullzer, @schiessle and @DeepDiver1975 to be potential reviewers |
|
64% (2.6 seconds) faster than before? Nice! 🚀 |
| * @param Node|null $node | ||
| * @param bool $reshares Also get the shares where $user is the owner instead of just the shares where $user is the initiator | ||
| * @return \OCP\Share\IShare[] | ||
| * @since 9.0.0 |
LukasReschke
force-pushed
the
share-types-by-folder
branch
from
1d0bf4f
to
fb7d7ab
Compare
|
@icewind1991 What is the status of this? |
|
Needs more work to implement this for the various sharing backends |
icewind1991
force-pushed
the
share-types-by-folder
branch
2 times, most recently
from
8b8f3f8
to
19c244e
Compare
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
share-types-by-folder
branch
from
19c244e
to
ce7eb02
Compare
* Merge share types correctly * Filter share types * Order share types Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
added
3. to review
|
Ok I think this is ready for review. |
|
👍 for @rullzer's changes Listing a ~1000 file folder goes from ~3000 queries to 48 😄 Tested by sharing some files and checking if they show up as shared in the file list |
|
LGTM |
schiessle
added a commit
that referenced
this pull request
Nov 1, 2016
Signed-off-by: Bjoern Schiessle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting share info for a folder, instead of looping over the childs and querying each one individually, use a single query to get the share status of all childs.
Gives a very significant improvement when loading large folders in the webui (not sure if the sync client is affected, depends on the properties requested)
TODO
cc @rullzer