Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtrim cloudId url earlier #33793

Merged
merged 1 commit into from
Sep 15, 2022
Merged

rtrim cloudId url earlier #33793

merged 1 commit into from
Sep 15, 2022

Conversation

ArtificialOwl
Copy link
Member

rtrim the url earlier, to compare a better formatted string. This will avoid address ending with /index.php/

Signed-off-by: Maxence Lange <[email protected]>
@PVince81
Copy link
Member

PVince81 commented Sep 1, 2022

@ArtificialOwl please set the labels, etc

@ArtificialOwl ArtificialOwl added bug 3. to review Waiting for reviews labels Sep 1, 2022
@ArtificialOwl ArtificialOwl added this to the Nextcloud 25 milestone Sep 15, 2022
@ArtificialOwl
Copy link
Member Author

(fail check does not seems related)

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ArtificialOwl ArtificialOwl merged commit 381eb04 into master Sep 15, 2022
@ArtificialOwl ArtificialOwl deleted the fix/noid/rtrim-cloud-id branch September 15, 2022 11:46
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants