Add a11y attributes for legacy app navigation #33746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
requested review from
nickvergessen,
JuliaKirschenheuter,
CarlSchwan,
Pytal and
marcoambrosini
4 tasks
Aded "role=navigation" Added "aria-current=page" for the currently selected item. Signed-off-by: Vincent Petry <[email protected]>
PVince81
force-pushed
the
a11y/33739/fix-legacy-nav
branch
from
ff20ec9
to
cc53efe
Compare
CarlSchwan
approved these changes
Aug 29, 2022
nickvergessen
approved these changes
Aug 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aded "role=navigation"
Added "aria-current=page" for the currently selected item.
For #33739