Fallback to root if the picker folder doesn't exists #33681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
artonge and
Pytal
and removed request for
a team
|
/rebase |
skjnldsv
commented
Aug 24, 2022
| @@ -1151,126 +1151,143 @@ const Dialogs = { | |||
| } else { | |||
| self.$fileListHeader.find('[data-sort=' + self.filepicker.sortField + '] .sort-indicator').addClass('icon-triangle-s') | |||
| } | |||
| self.filepicker.filesClient.getFolderContents(dir).then(function(status, files) { | |||
There was a problem hiding this comment.
This was invalid, returning multiple values from a promise is invalid
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/resolve#syntax
I couldn't fix the getFolderContents without risking breaking a lot of its usage
nextcloud-command
force-pushed
the
fix/picker-fallback-root
branch
from
8113448
to
2f9f93c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
CarlSchwan
approved these changes
Aug 31, 2022
This comment was marked as resolved.
This comment was marked as resolved.
nextcloud-command
force-pushed
the
fix/picker-fallback-root
branch
from
2f9f93c
to
4bf7781
Compare
This comment was marked as resolved.
This comment was marked as resolved.
szaimen
added
2. developing
Please don't add the missing files if you don't plan to merge straight away 🙈
Rebasing 😬 |
skjnldsv
added
4. to release
skjnldsv
force-pushed
the
fix/picker-fallback-root
branch
from
4bf7781
to
4f9f98c
Compare
|
/compile amend / |
Signed-off-by: John Molakvoæ <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/picker-fallback-root
branch
from
4f9f98c
to
96bbc1a
Compare
|
/backport to stable24 |
|
/backport to stable23 |
|
The backport to stable23 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on the Photos default folder picker, I noticed that if you call the
getFilePickerBuilderwith an invalid value/folder, it just exploded without loading anything.Adding this make sure we fallback to the user root
/if the provided directory i non-existent