Fix carddav activities

[nickvergessen]

The settings where combined last minute but at the same time the activities
where not adjusted to map an existing setting so the filter was not possible
to even limit it to the types that the activities had.

Unluckily this is not retro-active

Fix nextcloud/activity#856

[tcitworld]

Why does it work for activities of type calendars and calendar_events though?

[nickvergessen]

Why does it work for activities of type calendars and calendar_events though?

Because they have different settings https://github.com/nextcloud/server/tree/814d9ac74a7d673746dc2a2760a2b8f773523a08/apps/dav/lib/CalDAV/Activity/Setting

But it was requested to not do that for contacts. The main of caldav being different is also to be able to ignore todo changes while being notified about events.

[nickvergessen]

/backport to stable24

[nickvergessen]

/backport to stable23

[skjnldsv]

There were 16 failures:
447 |  
448 | 1) OCA\DAV\Tests\unit\CardDAV\Activity\BackendTest::testTriggerAddressBookActivity with data set #1 ('addressbook_add', array('principal/user/admin', 42, 'this-uri', 'Name of addressbook'), array(), array(), '', 'admin', null, array('admin'))
449 | Expectation failed for method name is "setType" when invoked 1 time(s)
450 | Parameter 0 for invocation OCP\Activity\IEvent::setType('contacts'): OCP\Activity\IEvent does not match expected value.
451 | Failed asserting that two strings are equal.
452 | --- Expected
453 | +++ Actual
454 | @@ @@
455 | -'addressbook'
456 | +'contacts'

[backportbot-nextcloud]

The backport to stable24 failed. Please do this backport manually.

[backportbot-nextcloud]

The backport to stable23 failed. Please do this backport manually.