Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't scan children from created directory #33612

Closed
wants to merge 1 commit into from

Conversation

CarlSchwan
Copy link
Member

We already know what there is no children so the size = 0 and we don't
need to propagate the new size to the children because x + 0 is still
equal to x

Remove some queries when doing a MKCOL

We already know what there is no children so the size = 0 and we don't
need to propagate the new size to the children because x + 0 is still
equal to x

Remove some queries when doing a MKCOL

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Aug 18, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Aug 18, 2022
@CarlSchwan CarlSchwan requested a review from a team August 18, 2022 13:06
@CarlSchwan CarlSchwan self-assigned this Aug 18, 2022
@CarlSchwan CarlSchwan requested review from ArtificialOwl, icewind1991 and come-nc and removed request for a team August 18, 2022 13:06
Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in the folder not being added to the cache at all (although this might be auto-repaired later on), additionally mtimes/etags still need to be propagated

@CarlSchwan CarlSchwan closed this Aug 19, 2022
@skjnldsv skjnldsv deleted the dont-scan-children-mkcol branch March 14, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants