Minor improvement to diagnostics - log user name in setupForUserWith #33426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dariusz Olszewski <[email protected]>
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
added
2. developing
Merged
|
Hi @starypatyk, looks like your PR got caught in a cleanup! I'm reopening this for you and will look into getting your change in. Cheers! |
sorbaugh
approved these changes
Aug 16, 2024
|
Hello again @starypatyk, while trying to resolve the conflict, we found out that we actually took another approach where the event got renamed/changed. So unfortunately we can't use your approach after all, hope that's alright! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating slow loading of chat messages in Talk/Android I have been struggling with understanding why setup_fs is called many times during a single request.
It turned out that the setupForUserWith method is called for all participants of the chat who shared images in the chat.
The proposed change makes this analysis a bit easier.