-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document pitfalls when building production assets #33322
Conversation
Otherwise building assets for production will fail CI due to differences. Signed-off-by: Vincent Petry <[email protected]>
Signed-off-by: Vincent Petry <[email protected]>
@@ -14,6 +14,9 @@ build-js: | |||
npm run dev | |||
|
|||
build-js-production: | |||
@echo Using node version $(shell node -v) and npm version $(shell npm -v) | |||
@echo Please make sure you are using the same version as recommended in the README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we instead read the environment from package.json?
Could even compare it and fail the make step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought of this but this was from the time I believed that my asset problem was related to node versions, but it wasn't, it was about the additional apps I didn't move to apps-extra, so not sure if we should be hard about node versions
Otherwise building assets for production will fail CI due to
differences.
Because it's super annoying to get CI fails despite having been nice enough to run
make build-js-production
(example: #33321)