Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document pitfalls when building production assets #33322

Closed

Conversation

PVince81
Copy link
Member

Otherwise building assets for production will fail CI due to
differences.

Because it's super annoying to get CI fails despite having been nice enough to run make build-js-production (example: #33321)

Otherwise building assets for production will fail CI due to
differences.

Signed-off-by: Vincent Petry <[email protected]>
@PVince81 PVince81 added the 2. developing Work in progress label Jul 22, 2022
@PVince81 PVince81 added this to the Nextcloud 25 milestone Jul 22, 2022
@PVince81 PVince81 self-assigned this Jul 22, 2022
@PVince81 PVince81 changed the title Document recommended node versions from CI Document pitfalls when building production assets Jul 26, 2022
@PVince81 PVince81 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 26, 2022
@PVince81 PVince81 marked this pull request as ready for review July 26, 2022 20:57
@@ -14,6 +14,9 @@ build-js:
npm run dev

build-js-production:
@echo Using node version $(shell node -v) and npm version $(shell npm -v)
@echo Please make sure you are using the same version as recommended in the README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead read the environment from package.json?
Could even compare it and fail the make step

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought of this but this was from the time I believed that my asset problem was related to node versions, but it wasn't, it was about the additional apps I didn't move to apps-extra, so not sure if we should be hard about node versions

This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
@PVince81 PVince81 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 16, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@PVince81
Copy link
Member Author

@skjnldsv @Pytal can you take over if this is still of interest ? otherwise feel free to close

@PVince81 PVince81 removed their assignment Mar 18, 2023
@skjnldsv skjnldsv closed this Mar 19, 2023
@skjnldsv skjnldsv deleted the bugfix/noid/recommended-node-npm-versions-for-ci branch March 19, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants