Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Doctrine ORM #33127

Closed
wants to merge 6 commits into from
Closed

Introduce Doctrine ORM #33127

wants to merge 6 commits into from

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Jul 5, 2022

TODOs:

  • EntityManager wrapper
  • EntityRepository wrapper
  • Query wrapper (for the DQL)
  • Command integration
  • Psr6 Cache wrapper around the ICache
  • Decide if we want a wrapper for the Mapping DTO class (lot of work
    not much benefits)

PR where this is used: nextcloud/social#1439

Signed-off-by: Carl Schwan [email protected]

@CarlSchwan CarlSchwan marked this pull request as draft July 5, 2022 22:46
@@ -0,0 +1,116 @@
<?php
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO finish

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 30 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 30 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 56 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 66 potential problems in the proposed changes. Check the Files changed tab for more details.

TODOs:

- [x] EntityManager wrapper
- [ ] EntityRepository wrapper
- [ ] Query wrapper (for the DQL)
- [x] Command integration
- [ ] Psr6 Cache wrapper around the ICache
- [ ] Decide if we want a wrapper for the Mapping DTO class (lot of work
  not much beneficts)

Signed-off-by: Carl Schwan <[email protected]>
Signed-off-by: Carl Schwan <[email protected]>
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 99 potential problems in the proposed changes. Check the Files changed tab for more details.

@szaimen szaimen added the 2. developing Work in progress label Apr 13, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone Apr 13, 2023
@skjnldsv skjnldsv mentioned this pull request May 3, 2023
@come-nc come-nc removed this from the Nextcloud 27 milestone May 4, 2023
@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
This was referenced Mar 12, 2024
@Altahrim Altahrim mentioned this pull request Mar 20, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 31 milestone Aug 14, 2024
@skjnldsv skjnldsv deleted the introduce/orm branch August 30, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants